Greg Stein wrote:
> On Fri, Feb 17, 2006 at 01:21:47PM +0000, Julian Foad wrote:
>
>>Justin Erenkrantz wrote:
>>
>>>Therefore, each variation would ultimately need its own #define and
>>>keeping track of that - since a #define would be separated from the
>>>actual loop into a header file (meaning every time I tweak it,
>>>everything in the library needs to be recompiled) - is what I feel
>>>isn't right at this early stage. -- justin
>>
>>FWIW, a #define doesn't have to be in a header file just because it's a
>>#define, only if it is intended to be shared. If it's only for local use
>>in one C file it belongs in that file.
>
> If it is used in one place, and the intended use for the value is
> obvious (as it is in this case), then a symbol doesn't help much.
>
> IMO, find another thing to nitpick that has more benefit :-)
Yep, I should have restrained myself from sending that email. Sorry folks.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 17 17:49:18 2006