[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18486 - trunk/subversion/libsvn_ra_serf

From: Greg Stein <gstein_at_lyra.org>
Date: 2006-02-17 17:17:26 CET

On Fri, Feb 17, 2006 at 01:21:47PM +0000, Julian Foad wrote:
> Justin Erenkrantz wrote:
> >Therefore, each variation would ultimately need its own #define and
> >keeping track of that - since a #define would be separated from the
> >actual loop into a header file (meaning every time I tweak it,
> >everything in the library needs to be recompiled) - is what I feel
> >isn't right at this early stage. -- justin
> FWIW, a #define doesn't have to be in a header file just because it's a
> #define, only if it is intended to be shared. If it's only for local use
> in one C file it belongs in that file.

If it is used in one place, and the intended use for the value is
obvious (as it is in this case), then a symbol doesn't help much.

IMO, find another thing to nitpick that has more benefit :-)


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 17 17:28:03 2006

This is an archived mail posted to the Subversion Dev mailing list.