Re: [PATCH] Extra options for libsvn_diff

On 2/16/06, Julian Foad <julianfoad@btopenworld.com> wrote:

> I don't know. Again, it's a matter of how we look at the situation. I think
> that if we add this then we should be willing to add "--show-pascal-function",
> "--show-xml-element", "--show-python-function", "--show-docbook-lite-section",
> and so on whenever people want them. I'm serious, and maybe that's OK.

I would be perfectly willing to add such features if:

1) They didn't overly complicate the diff code
2) They didn't come with heavyweight external dependencies
3) Someone actually volunteered to write them
4) They work acceptibly well

I think the -p option fits all of those requirements.

As for why I want to have it built in as opposed to using GNU diff,
well, it's partially that I like eating our own dogfood, so I use our
diff impl as the default, and thus when I want -p I have to add
--diff-cmd diff to my command line, and it's partly that I sometimes
work on platforms that don't necessarily have GNU diff installed
(windows, solaris, etc), and it's nice for all the same functionality
to be there.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 16 22:02:08 2006