[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Ignoring space changes, but not all space changes

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-02-16 21:31:04 CET

On Thu, 16 Feb 2006, Julian Foad wrote:

> Right, please don't flame me. This is a rambling train of thought that I might
> not still agree with after due consideration and hearing others' thought.
>

Flame, flame, flame! :-)
>
> In our plan to support ignoring space changes in "diff", and then "blame" and
> presumably "merge" and perhaps "update", Peter has started by implementing
>
> ignore-space-change
> ignore-all-space
> ignore-eol-style
>
> But what do we really want?
>
> When I said I wanted "svn up" to ignore whitespace, Stefan Haller wrote:
> > I must be misunderstanding what you have in mind here, but if it is what
> > I think it is, then I don't think this is a good idea. In C, whitespace
> > is only insignificant between tokens; in string literals it is probably
> > significant. And in python, you sure don't want to silently ignore it
> > if someone changes
> >
> > if x:
> > foo()
> > bar()
> >
> > to
> >
> > if x:
> > foo()
> > bar()
>
> He's quite right. What we really want, right now, is (Use Case 1) to ignore
...

I think these options are generally useful. Using them for languages tha
relies on whitespace extensively seems wrong to me

For a language like C or Java, they will most often dtrt, and I think that
if you use these options, you need to be careful and check the results.
Adding a lot of different --ignore-whitespace-blah options seems to go
overboard to me.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 16 21:33:16 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.