Re: problem revealed by issue #2398 (server-side assertion)

On Mon, 13 Feb 2006, Garrett Rooney wrote:

> On 2/13/06, kfogel@collab.net <kfogel@collab.net> wrote:
>
> > Any thoughts about this patch's general approach?
>
> Why change from an assert to a SVN_ERR? The assert was wrong because
> of the pointer comparison, not because of what it's testing, it's
> still fundamentally misusing the API to pass two different filesystems
> to this function, so why not make it an assert?
>
In this particular case, I think changing to an error is appropriate
because the fs uuid might change, either between the calls, or (if it is
cached) between the two FS objects were opened. We can't let that scenario
crash anything.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 14 07:55:14 2006