[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: problem revealed by issue #2398 (server-side assertion)

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-02-14 00:31:15 CET

On 2/13/06, kfogel@collab.net <kfogel@collab.net> wrote:

> Any thoughts about this patch's general approach?

Why change from an assert to a SVN_ERR? The assert was wrong because
of the pointer comparison, not because of what it's testing, it's
still fundamentally misusing the API to pass two different filesystems
to this function, so why not make it an assert?

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 14 00:31:45 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.