Re: [PATCH] #1 Update on port to OS400/EBCDIC

rooneg@gmail.com wrote on 02/13/2006 01:16:25 PM:

> On 2/13/06, Paul Burba <paulb@softlanding.com> wrote:
>
> > /* Else, parse options. */
> > - apr_getopt_init (&os, pool, argc, argv);
> > + svn_cmdline_getopt_init (&os, pool, argc, argv);
>
> If svn_cmdline_getopt_init is going to return a svn_error_t it really
> needs to be checked, rather than just ignored. Not that the existing
> code was doing so well in that department mind you, but it's still
> wrong.
>
> -garrett

Hi Garrett,

Assuming the rest of the patch gets a clean bill of health, I'll add the
following for each main() function, with the appropriate "svn*: " prefix
for each of course.

- apr_getopt_init (&os, pool, argc, argv);
+ err = svn_cmdline_getopt_init (&os, pool, argc, argv);
+ if (err)
+ return svn_cmdline_handle_exit_error (err, pool, "svn: ");

Thanks,

Paul B.

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 13 19:54:57 2006