[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Flush stdout more often

From: Michael Sinz <Michael.Sinz_at_sinz.org>
Date: 2006-02-12 00:03:24 CET

Justin Erenkrantz wrote:
> On 2/11/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
>> I just checked out a copy of trunk from the svn repository. That produced
>> 1367 lines of output and strace reports 123426 syscalls (that's the number
>> of lines output by strace). So, in the case where fflush *is* an extra
>> syscall per line, would you mind estimating the actual overhead in time?
>> (This is a rethorical question, sorry). I think this is microoptimization.
>
> The addition of this patch is cruft to support a tool that shouldn't
> be dependent upon line-buffering at all. There are far cleaner ways
> to build applications on top of Subversion that don't require us to
> put in ugly hacks in our code.

I don't fully understand why this is considered an ugly hack. Nor do I
understand the next point...

>> Note that we already have a fflush (per character) when we output the dots
>> while transfering files, because we want the dots to show up immediately.
>
> Yes, but that's because we feel we need it for our users. We don't
> put it there because someone doesn't like our default notification
> callback.

I don't know about others, but let us not forget the history of Unix systems
and the power and versatility of pulling together tools via just the STDIO
command line programs. This provides major flexibility and loosely coupled
systems that can scale amazingly well. (And, yes, manytimes that means
less efficient but efficient enough is all that really matters...)

>> As others pointed out, being script friendly is important. Why do we
>> otherwise have a locale-independent date in the log output (and the number
>> of lines in the log message printed)?
>
> Parsable? Sure. That level of streamy? Nah. -- justin

Streamy is a good thing - think of the system scalability by having it more
streamy - more parallelism, which multi-processor systems can really take
advantage of. (cmd1 | cmd2 | cmd3 with streamy commands scales beautifully
into a 3+ processor setup)

-- 
Michael Sinz                     Technology and Engineering Director/Consultant
"Starting Startups"                                mailto:michael.sinz@sinz.org
My place on the web                            http://www.sinz.org/Michael.Sinz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 12 00:04:37 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.