Re: [PATCH] Flush stdout more often

On 2/11/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> I just checked out a copy of trunk from the svn repository. That produced
> 1367 lines of output and strace reports 123426 syscalls (that's the number
> of lines output by strace). So, in the case where fflush *is* an extra
> syscall per line, would you mind estimating the actual overhead in time?
> (This is a rethorical question, sorry). I think this is microoptimization.

The addition of this patch is cruft to support a tool that shouldn't
be dependent upon line-buffering at all. There are far cleaner ways
to build applications on top of Subversion that don't require us to
put in ugly hacks in our code.

> Note that we already have a fflush (per character) when we output the dots
> while transfering files, because we want the dots to show up immediately.

Yes, but that's because we feel we need it for our users. We don't
put it there because someone doesn't like our default notification
callback.

> As others pointed out, being script friendly is important. Why do we
> otherwise have a locale-independent date in the log output (and the number
> of lines in the log message printed)?

Parsable? Sure. That level of streamy? Nah. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 11 23:25:28 2006