[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [Issue 1942] svn+ssh should use the port value

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-02-07 12:28:48 CET

Hi All,
Finally the problem seems to be improper ssh key configuration in my box.
I posted the similar cause on 5th December 2005 with a Message-ID:
<4394242D.1040808@collab.net>.

The only real failure is 'switch_tests.py 16: relocate with prefixes
longer than repo root '

This test consistently fail for svn+ssh urls even on 1.3.0

Problem seems to be that expected regex has unescaped '+'. (as in
svn+ssh rather it should be svn\+ssh)

Will post a patch along with my fix for #1942 after incorporating
Brane's comment on #1942.

With regards
Kamesh Jayachandran

Kamesh Jayachandran wrote:
> Got the reason for commit_tests failure, while addressing that cause
> the number of failures have come down to the following from original 16.
>
> FAIL: switch_tests.py 16: relocate with prefixes longer than repo root
> FAIL: stat_tests.py 17: status output in XML format
> FAIL: blame_tests.py 4: blame output in XML format
> FAIL: lock_tests.py 1: lock a file and verify that it's locked
> FAIL: lock_tests.py 7: examine the fields of a lockfile for correctness
>
> The cause of the commit_tests failure was my PATH varaible.
> For all my testing I build and install to install area identified by
> the defect id something like /path/to/install/area/1942 etc.
> The svn+ssh makes use of the svnserve binary available in the PATH as
> against my custom install area, as I had subversion 1.3.0 in the PATH.
> The 1.3.0 version of subversion does not seem to be capable of passing
> the post commit error back to client as against the trunk.
>
> Will investigate the cause of the above failures and incorporate
> Brane's comments and post the patch.
>
> With regards
> Kamesh Jayachandran
>
> kfogel@collab.net wrote:
>> Branko Čibej <brane@xbc.nu> writes:
>>
>>> Kamesh Jayachandran wrote:
>>>
>>>> Hi All,
>>>> I hereby attach patch for #1942.
>>>>
>>>> Ran make check/make autodavcheck found nothing alarming.
>>>> Ran make svnsshcheck found 16 tests failing with and without this
>>>> patch and hence attribute the failures to out of date work area and
>>>> submit this patch.
>>>>
>>> You mean you didn't actually check why those tests were failing?
>>> That's not nice at all.
>>>
>>
>> Kamesh, did you mean "attribute the failures to causes independent of
>> my changes"? That's very different from "out of date work area", but
>> it would make a lot more sense in context.
>>
>> (Were the 16 failures exactly the same failures both and without your
>> changes? Do you know what's causing them?)
>>
>> -Karl
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 7 12:29:25 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.