Re: [PATCH] Script for warning about error leaks

On 2006-02-06 15:01:08 +0000, Julian Foad wrote:
> Vincent Lefevre wrote:
> >On 2006-02-06 00:49:59 +0000, Julian Foad wrote:
> >
> >>Here is such a script, proposed for addition to the "tools/dev/"
> >>directory.
> >
> >Shouldn't you make it locale-insensitive by setting LC_ALL to "C"?
>
> Um, I've no idea. Should I? What might go wrong in other locales?

In the script, you have:

  IDENT="[a-zA-Z_][a-zA-Z0-9_]*"

I think this regexp should be OK with any locale, though. Range
expressions, such as [a-z], depend on the locale. For instance,
[a-z] may include uppercase and/or accented characters. If one
day, you need a case-sensitive regexp using range expressions,
you need to remember to force the locale to C.

For instance, under some systems with en_US.UTF-8, [a-z] includes
uppercase letters.

-- 
Vincent Lefèvre <vincent_at_vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / SPACES project at LORIA
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org