[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18308 - trunk/subversion/libsvn_ra_serf

From: Greg Stein <gstein_at_lyra.org>
Date: 2006-02-01 03:41:54 CET

On Tue, Jan 31, 2006 at 08:26:18PM -0600, jerenkrantz@tigris.org wrote:
>...
> +++ trunk/subversion/libsvn_ra_serf/serf.c Tue Jan 31 20:26:17 2006
> @@ -1100,9 +1100,12 @@
> report_state_list_t *state;
> report_state_list_t *free_state;
>
> - /* pending fetches */
> + /* pending GET requests */
> report_fetch_t *active_fetches;
>
> + /* pending PROPFIND requests */
> + propfind_context_t *active_propfinds;

Why track these instead of just using a count? The only thing which
needs the context is the response handler, and it already gets them as
part of the process. You don't have to link-list them, nor prune them,
if you merely keep a counter around.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 1 03:38:53 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.