On Tue, Jan 31, 2006 at 08:17:04PM -0600, jerenkrantz@tigris.org wrote:
> Author: jerenkrantz
>...
> +++ trunk/subversion/libsvn_ra_serf/serf.c Tue Jan 31 20:17:03 2006
>...
> +/**
> + * This function will deliver a PROP_CTX PROPFIND request in the SESS
> + * serf context for the properties listed in LOOKUP_PROPS at URL for
> + * DEPTH ("0","1","infinity").
> + *
> + * This function will not block waiting for the response. Instead, the
> + * caller is expected to call context_run and wait for the PROP_CTX->done
> + * flag to be set.
> + */
> static svn_error_t *
> -retrieve_props (apr_hash_t **prop_vals,
> - serf_session_t *sess,
> - const char *url,
> - const char *depth,
> - const dav_props_t *props,
> - apr_pool_t *pool)
> +deliver_props (propfind_context_t **prop_ctx,
> + apr_hash_t *prop_vals,
> + serf_session_t *sess,
> + const char *url,
> + const char *depth,
> + const dav_props_t *lookup_props,
> + apr_pool_t *pool)
I'd suggest interpreting lookup_props to mean, "look up <these>
properties; otherwise, if NULL, then fetch all properties."
That should simplify things within the function an the callers.
>...
> +/**
> + * This helper function will block until the PROP_CTX indicates that is done
> + * or another error is returned.
> + */
> +static svn_error_t *
> +wait_for_props(propfind_context_t *prop_ctx,
> + serf_session_t *sess,
> + apr_pool_t *pool)
Seems that you could make a generic blocking function that takes a
pointer to a boolean.
>...
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 1 03:33:43 2006