[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][Issue 2295]"svn mkdir URL" gives poor error message when directory exists

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-01-30 14:53:43 CET

Kamesh Jayachandran wrote:
> Index: subversion/mod_dav_svn/repos.c
> ===================================================================
> --- subversion/mod_dav_svn/repos.c (revision 18117)
> +++ subversion/mod_dav_svn/repos.c (working copy)
> @@ -1544,6 +1544,14 @@
> "trailing slash on the URI.");
> }
>
> + if ((strcmp(r->method, "MKCOL") == 0) && comb->res.exists)
> + {
> + r->status_line = apr_pstrdup(r->pool, "409 Directory already exists");
> + return dav_new_error(r->pool, HTTP_CONFLICT,
> + SVN_ERR_APMOD_DIRECTORY_EXISTS,
> + "Directory already exists");
> + }
> +
> *resource = &comb->res;
> return NULL;

No mention of the "r->method" nor "r->status_line" members nor any string
comparison with a method name appears anywhere else in mod_dav_svn. This
strikes me as odd, perhaps indicating that this is not the right way to detect
and set such an error.

Note that this code is within the "get resource" function, not within the
"create collection" function. Perhaps if it is being called with a "MKCOL"
method, it is being called wrongly.

Disclaimer: I have no mod_dav_svn knowledge; these are just observations.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 30 14:55:35 2006

This is an archived mail posted to the Subversion Dev mailing list.