[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Space-before-paren or not?

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-01-29 21:59:04 CET

On Sun, 29 Jan 2006 kfogel@collab.net wrote:

> (Sorry to miss the beginning of this thread -- I was busy freezing my
> pons off in Poland.)
Oh, you've been missing a terrible week or so. Make sure to print out the
archives and read them before sleep:-)

> It was probably a mistake to allow inconsistent function-call
> formatting when the project started. We should have picked a style
> and stuck with it. The inconsistency has added overhead to patch
> review, plus generated some threads on this list.
Yeah, if I only was there to tell you back then:-) Seriously, I didn't
think of this as a problem when I first read HACKING, probably about two
years ago. So I can't really blame the ones who made the decission.
Now, some reviews and patch-processing episodes later, I've been
enough frustrated to take this thus far. That might say something about
me, or about the overhead it causes... =)

> Statistics on function call formatting in our C code:
> * space-before-paren (16 modules, 123546 lines of code, 77% by line):
> libsvn_auth, libsvn_client, libsvn_delta, libsvn_fs,

What's libsvn_auth?

> libsvn_fs_base, libsvn_fs_fs, libsvn_ra, libsvn_ra_local,
> libsvn_repos, libsvn_subr, libsvn_wc, svn, svnadmin,
> svndumpfilter, svnlook, svnsync
> * no-space-before-paren (6 modules, 36069 lines of code, 23% by line):
> libsvn_diff, libsvn_ra_dav, libsvn_ra_svn, mod_authz_svn,
> mod_dav_svn, svnserve
> * seems to use both styles (1 module, 263 lines of code, ~0% by line):
> svnversion

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jan 29 21:59:39 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.