[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[API] r18266

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-01-28 23:03:26 CET

Julian,

In r18266, you added a new API svn_wc_revision_status with a pointer to
struct svn_wc_revision_status_t, which will be filled by the function.
This avoids lots of "out" parameters in the function, but it still makes
it impossible to add new fields to the struct without revving both the
struct and the function (which might be another reason for using a struct
in the first place).

I suggest making the function allocate the struct and adding to the struct
doc a note that the size of this struct may increase in the future, so
callers shouldn't create it themselves. (We can add constructors like
we've done for other structs now or on demand later).

We've made this mistake before leading to lots of API revision.

Thoughts?
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 28 23:03:44 2006

This is an archived mail posted to the Subversion Dev mailing list.