[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18260 - trunk/subversion/libsvn_ra_serf

From: Greg Stein <gstein_at_lyra.org>
Date: 2006-01-27 11:28:07 CET

On Fri, Jan 27, 2006 at 09:42:31AM +0100, Peter N. Lundblad wrote:
>...
> > - /* todo: create a subpool? */
> > - serf_sess->pool = pool;
> > + apr_pool_create(&serf_sess->pool, pool);
>
> Should be svn_pool_create, but why do you need a subpool?

Right. Unless it is going to be cleared at some points, then a subpool
isn't going to be all that helpful.

>...
> > + vcc_url = fetch_prop(props, sess->repos_url.path, "DAV:",
> > + "version-controlled-configuration");
> > +
> Wouldn't it be better to have #defines for these string constants, making
> it harder to misspell them?

If it gets misspelled, then it simply won't work. The failure mode is
direct and obvious, so a symbolic conatant isn't going to improve
things.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 27 11:25:55 2006

This is an archived mail posted to the Subversion Dev mailing list.