[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18218 - in trunk: . subversion/libsvn_ra_serf

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-01-26 01:35:12 CET

On Wed, 25 Jan 2006, Greg Stein wrote:

> On Wed, Jan 25, 2006 at 10:44:45PM +0100, Peter N. Lundblad wrote:
> >...
> > I won't go on pushing this issue, because we can spend our lifes on more
> > useful stuff than style discussions and I guess this debate has been up
> > before. I just want to point out that anyones personal preference is
> > rather irrelevant here. My motivation is maintainability.
>
> Personal preference *is* relevant. That was defined long ago. An
> author (not-really when starting a new file, but definitely for a
> whole library) can choose to use space-before-paren on function calls,
> or no-space. And it should be consistent. But the choice has been
> there since the SVN project started nearly six years ago.

Clearly; we're still suffering from it today. I hate the
space-before-paren style, but more of the code is written in that
style, and like Lundblad, I'd rather keep things consistent for easier
maintenance and a lower barrier-to-entry.

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Thu Jan 26 01:35:11 2006

This is an archived mail posted to the Subversion Dev mailing list.