r14401 and copy mydir mydir

Hi,

In r14401, an issue (2224) was fixed making commands like
svn cp wcdir wcdir
not get stuck in an infinite loop. This was fixed by allowing this
operation as a special case. This operation will result in a directory
wcdir begin created as a child of wcdir (as one could expect). But, if
you do
svn cp wcdir wcdir/wcdir
you'll get an error about not being able to copy a path into its own
child. This also holds if you try to copy a WC dir into a deeper
descendant.

I stumbled on this while working on making svn_client_copy always fail if
the target exists because the new code will fail even in the special case
mentioned above.

I wonder why we support this case at all. I think the right fix should
have been to disable this case (which was, presumably, supported by
accident because the child was added after the check).

Does anyone feel we have to maintain this special case, or is it OK to
just remove it and fix copy_test 29 to expect failure?

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 25 23:41:05 2006