[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][Issue 2287] svn_client_log should take a peg revision

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-01-25 20:20:30 CET

On Tue, 24 Jan 2006, Malcolm Rowe wrote:

> On Thu, Jan 19, 2006 at 01:35:22PM -0800, Daniel Rall wrote:
> > I've committed a patch adding support for peg revisions to 'svn log'
> > (and of course the corresponding underlying APIs), based on work by
> > myself and Ramaswamy (and all the reviews that work received):
> >
> > http://svn.collab.net/viewcvs/svn?rev=18179&view=rev
> >
> > This feature should first be available in Subversion 1.4.0.
>
> Excellent. What should the behaviour of 'svn log foo@PEG' be, if no
> revision range is provided? Should it still be -rHEAD:1, as it is now
> (I think), or should it be -rPEG:1, which might be more in-line with
> the other commands that operate on peg-revs.
>
> See http://svn.haxx.se/dev/archive-2006-01/0352.shtml for an equivalent
> patch I proposed for 'svn blame', though note here that we have no
> backward-compatibility concerns.

As Peter Samuelson, I prefer PEG to HEAD on the grounds of both
consistency and usability. I'll come up with a XFail regression test
for 'svn log' to get us started.

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Wed Jan 25 20:30:42 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.