[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18194 - in trunk/subversion: include libsvn_client libsvn_subr svn

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-01-25 09:05:43 CET

On Tue, 24 Jan 2006, D.J. Heap wrote:

> On 1/23/06, lundblad@tigris.org <lundblad@tigris.org> wrote:
> > Author: lundblad
> > Date: Mon Jan 23 04:52:29 2006
> > New Revision: 18194
> [sinp]
> >
> > Log:
> > Fix issue #1809: Replace svn_client_ls and make recursive ls streamy. Make it
> > possible to determine if the target of an svn_client_list is a file or
> > directory by always including the listed target dirent in the result.
> [sinp]
>
>
> I believe there is a pool lifetime issue with the path name when using
> the old list functions -- I get strange/erratic results unless I tweak
> the store_entries function to dupe the path into the lb->pool before
> it is set as the hash key. Attached is an obvious quickie-patch, but
> I'm not sure it's the most correct.

Obviously, yes! Thanks for catching. Would you mind committing that? (I
have another patch in my WC currently, but I can do it if you don't.)

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 25 09:06:31 2006

This is an archived mail posted to the Subversion Dev mailing list.