[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18214 - in trunk: . build/ac-macros subversion/include subversion/libsvn_ra subversion/libsvn_ra_serf

From: Greg Stein <gstein_at_lyra.org>
Date: 2006-01-25 05:45:56 CET

On Tue, Jan 24, 2006 at 08:31:32PM -0800, Justin Erenkrantz wrote:
>...
> I thought so too, but there's this nice todo in ra_loader.c:
>
> * ### todo: Any RA libraries implemented from this point forward
> * ### don't really need an svn_ra_NAME_init compatibility function.
> * ### Currently, load_ra_module() will error if no such function is
> * ### found, but it might be more friendly to simply set *COMPAT_FUNC
> * ### to null (assuming COMPAT_FUNC itself is non-null).
>
> So, I'm not sure setting compat_init field to NULL would actually
> work. There are some files in trunk that still use
> svn_ra_get_ra_library. If they were to request the 'http' or 'https'
> scheme when ra_serf was loaded instead of ra_dav, an error would be
> returned. If a program worked with svn 1.0 that expected 'http', it'd
> fail if serf were included unless the compat init was present...

Ah. Right. The "look up the entry point in the DSO" thing. Shoulda
remembered that, as I wrote that code :-P

I was looking at it from the angle of somebody directly calling it
from some client code.

Thx,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 25 05:42:37 2006

This is an archived mail posted to the Subversion Dev mailing list.