[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: More error leaks

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-01-25 01:29:30 CET

Malcolm Rowe wrote:
> On Thu, Jan 19, 2006 at 04:10:21PM +0000, Julian Foad wrote:
>
>>By putting "__attribute__((warn_unused_result))" on each declaration of a
>>function that returns "svn_error_t *", I found the following errors being
>>leaked:
>
> Fantastic job, Julian! I fixed all the trivial instances in r18196.

Thanks, Malcolm. Now I've done the same on static functions and found four
more (with my comments):

subversion/libsvn_wc/adm_files.c: In function 'init_adm':
subversion/libsvn_wc/adm_files.c:1037: return value of 'make_empty_adm'
   Should use SVN_ERR.

--
subversion/libsvn_wc/entries.c: In function 'svn_wc__entries_write':
subversion/libsvn_wc/entries.c:1287: return value of 'write_entry'
   Should return "void".
--
subversion/svndumpfilter/main.c: In function ‘new_node_record’:
subversion/svndumpfilter/main.c:529: return value of 'output_revision'
   Should use SVN_ERR.
--
subversion/mod_dav_svn/update.c: In function 'upd_open_directory':
subversion/mod_dav_svn/update.c:739: return value of 'open_helper'
   Caller should just return the error, like the nearby functions do.
If you'd care to fix those too that would be nice.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 25 01:29:50 2006

This is an archived mail posted to the Subversion Dev mailing list.