Re: svn commit: r18144 - in trunk/subversion/libsvn_fs_base: . bdb

Branko Èibej <brane@xbc.nu> writes:

> Malcolm Rowe wrote:
>>
>> You'd defined bdb_cache_state as 'volatile void *', and so you're passing
>> a 'volatile void **' to apr_atomic_casptr(), for which the default
>> (macro) implementation of casts its first argument to (apr_uint32_t *)
>> - see include/apr_atomic.h:285. Isn't that a type-punned pointer?

Malcolm is describing the 0.9.x version of apr_atomic.h which includes
a (Linux only?) macro implementation in the public header file

> The prototype for apr_atomic_casptr says that the first parameter is
> volatile void **. If there's a macro doing a cast getting in between,
> then that's a bug in APR and should be reported there.

while Branko is describing 1.2.x which no longer includes the macro.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org