Re: More error leaks

On Thu, 19 Jan 2006, Julian Foad wrote:

> By putting "__attribute__((warn_unused_result))" on each declaration of a
> function that returns "svn_error_t *", I found the following errors being leaked:
>
...

Nice job, Julian!

> Of course the other question raised is: do we want to consider using such
> attributes as a matter of course? Obviously only if it is done neatly and in a
> way that doesn't interfere with other compilers; macros can help to achieve
> that. I'll have a bit more of a think about that.
>
I think that'd be a great idea! This is a warning that's very useful.

FYI, APR already defines __attribute__ to nothing on non-GCC compilers, so
we could just add the attributes as we've done with printf-like functions.
But we may want to define some macro for it for clarity or
unclumsyfication purposes:-)

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 20 01:19:28 2006