[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] mailer.py

From: Mathias Weinert <mathias.weinert_at_gfa-net.de>
Date: 2006-01-19 18:00:50 CET

Max Bowsher <maxb1@ukf.net> wrote:

> Mathias Weinert wrote:
> > As already mentioned earlier I want to provide some new features
> > to mailer.py. In preparation of this I will step by step send
> > some smaller patches first (thank you maxb for applying the
> > latter ones!).
> >
> > Mathias
> >
> > [[[
> > * tools/hook-scripts/mailer/mailer.py
> > - typo corrected
>
> Thanks, committed.
>
> > - mailer.conf now has a format number to be able to change existing configuration options (not used yet)
>
> Without the context of what future use you want to put this option to,
> it is impossible to form an opinion on whether it is the right thing to
> do. Hence, not committed now - please provide further info.

Okay, you are absolutely right.
I will send more info (hopefully tomorrow).

>
> > * tools/hook-scripts/mailer/mailer.conf.example
> > - new option 'conf_format' to determine the version of the config file
>
> Same as before.
>
> > - some textual corrections
>
> Thanks, committed. (Except the one about generate_diffs, which changed
> one incorrect statement into a different incorrect statement - I'll
> rewrite that block of text now.)

Thanks (also for the other commits)

>
> > - deprectaed option 'suppress_deletes' set to comment as default
>
> Thanks, committed.
>
> > - second example for maps added
> > ]]]
> ...
> > +#
> > +# EXAMPLE 2:
> > +#
> > +# We want to map the complete repository path to a name which shall
> > +# be used for the commit subject prefix. This may be used e. g. if
> > +# one config file is used for some different repositories.
> > +# In order to be able to also use this for windows paths we do a
> > +# 'little trick' to elimante the colon ':' from the path.
> > +# Please note the missing colon in the second repository path.
> > +# The third one may be the resulting repository path under cygwin
> > +# (again with the colon eliminated).
> > +#
> > +#[defaults]
> > +#for_repos = (?P<repospath_1>[^:]*):?(?P<repospath_2>[^:]*)
> > +#commit_subject_prefix = %(repospath_1)s%(repospath_2)s
> > +#
> > +#[maps]
> > +#commit_subject_prefix = [repositories]
> > +#
> > +#[repositories]
> > +#/usr/svn/repos = Linux repository:
> > +#d/Subversion/repos = Windows repository:
> > +#/d/Subversion/d/Subversion/repos = Windows repository:
> > +#
>
> This example is essentially a repeat of the existing one, but:
> * for commit_subject_prefix instead of from_addr/to_addr.
> * demonstrating the 'little trick'
>
> Whilst I agree some explicit mention of the limitations of configuration
> keys might be appropriate in the [maps] documentation, I feel that this
> situation is perhaps a little too special-case for the example config file.
>
> Very many sites ought to be able to achieve the same ends with less
> complication by just matching the last one or two path elements from the
> repository path.

Okay, so just let this patch be :-)

Mathias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 19 22:41:23 2006

This is an archived mail posted to the Subversion Dev mailing list.