[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18144 - in trunk/subversion/libsvn_fs_base: . bdb

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-01-19 01:06:31 CET

On Wed, 18 Jan 2006, Branko Čibej wrote:

> Branko Čibej wrote:
> >Peter Samuelson wrote:
> >>[brane@tigris.org]
> >>
> >>>-svn_fs_bdb__dberrf (bdb_errcall_baton_t *ec_baton,
> >>>- int db_err, const char *fmt, ...)
> >>>+svn_fs_bdb__dberrf (bdb_env_baton_t *bdb_baton,
> >>>+ int db_err, const char *fmt, ...)
> >>>
> >>
> >>A few ^I slipped in at some point. I wouldn't have noticed except that
> >>it's aligned for 4-space tabs, not 8-space tabs.
> >>
> >Ouch! Thanks for noticing this; I can't imagine how I did this, since
> >I use an editor that's smart enough to not insert tabs into source
> >files... I'll fix it.
> Heh, I found 6 tabs in the BDB back-end, five of which weren't my fault. :)
> Fixed in r18164.
>
> So I did a full search thought our code, and found lots and lots of
> tabs. JavaHL/native has most of them.

The JavaHL code is riddled with them. :-\

Shall I get rid of them?

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Thu Jan 19 03:02:20 2006

This is an archived mail posted to the Subversion Dev mailing list.