Re: svn commit: r18040 - in trunk/subversion: libsvn_delta libsvn_fs_fs libsvn_ra_dav libsvn_ra_svn libsvn_repos libsvn_subr libsvn_wc svn tests/libsvn_delta

Daniel Rall <dlr@collab.net> writes:

> On Wed, 18 Jan 2006, Philip Martin wrote:
>
>> Daniel Rall <dlr@collab.net> writes:
>>
>> > * configure.in
>> > (OVERRIDE_CFLAGS): Add new substitution used when the compiler (CC)
>> > is gcc, tacking "-Wno-uninitialized" onto the end of the
>> > compilation flags. This additional substitution is necessary
>> > because GCC 4.0.1 takes argument ordering of such flags into
>> > consideration, and the flags may need to be positioned after
>> > EXTRA_CFLAGS to take affect.
>>
>> Why should -Wno-uninitialized override EXTRA_CFLAGS? I thought that
>> EXTRA_CFLAGS was *intended* to override the other CFLAGS.
>
> Because the command-line positioning of gcc's compilation flags
> impacts their interpretation, '-Wall -Werror -Wno-uninitialized'
> works, while '-Wno-uninitialized -Wall -Werror' fails (I assume
> because -Wall clobbers -Wno-uninitialized).

I know that, but I don't see why that means -Wno-uninitialized in the
Makefile has to override EXTRA_CFLAGS. EXTRA_CFLAGS is the way a user
can override whatever is in the Makefile, you are making it impossible
to override -Wno-uninitialized.

If configure is going to put both -Wall and -Wno-uninitialized in the
Makefile then it needs to ensure that they are in the right order, but
they should both go before EXTRA_CFLAGS.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org