[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18040 - in trunk/subversion: libsvn_delta libsvn_fs_fs libsvn_ra_dav libsvn_ra_svn libsvn_repos libsvn_subr libsvn_wc svn tests/libsvn_delta

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-01-17 10:06:43 CET

On Tue, 17 Jan 2006, Philip Martin wrote:

> definitely defeats valgrind which can detect such uses if they get
> tested.
>
> It's possible to stop gcc reporting these warnings with
> '-Wno-uninitialized' although that will also stop the warnings that
> are not 'false alarms'. It's possible to change the optimiser with
> '-fno-unit-at-a-time' but that might reduce the optimisation. I don't
> know if we can tell the optimiser about the non-NULL return of
> svn_error_create, but I think not.
>
> Maybe we are stuck with these initialisations, but it does make me a
...

As I indicated in another mail, I think disabling this warning is the
solution. Having valgrind indicate uninitialized data is much more
valuable than relying on this unreliable GCC warning (even though valgrind
is not used as much as it should). The worst thing is having to
initialize "out parameters" to an arbitrary value before calling a
function.

And, since this is most often a false alarm, the natural reaction after
some time will be to just add an initializer, possibly missing a real
error.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 17 10:14:14 2006

This is an archived mail posted to the Subversion Dev mailing list.