[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for contrib/client-side/svncopy.pl.in

From: Michael W Thelen <mike_at_pietdepsi.com>
Date: 2006-01-14 08:07:41 CET

Julian Foad wrote:
>> I've reattached Robert's patch as text/plain (I think!)... it's very
>> small. If no one responds in a day or two, I'll file an issue for it in
>> the issue tracker.
> Thanks for reminding us, Michael. The attachment as text/plain was
> fine, but please could you re-send it with a log message, or at least
> Robert's description of what problem this fixes if he didn't supply an
> actual log message. Thanks.

You bet! Sorry I didn't think of that. Here's what Robert said about
the patch. The log message wasn't very complete. I've also reattached
the patch.

Robert Reeves wrote:
> The current version has logic to delete the temp directory created by
> the svncopy.pl script. However, it wasn't implemented. This patch
> corrects that.
> [[
> Fix that enables temp dir deletion.
> ]]

Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams

Index: svncopy.pl.in
--- svncopy.pl.in (revision 17739)
+++ svncopy.pl.in (working copy)
@@ -259,6 +259,7 @@
   chdir( $startdir );
   print "=== ... copy complete\n";
+ Temp::Delete->DESTROY($auto_temp_dir);
   print "=================================================================\n";
   # Return whether there was an error.
@@ -951,7 +952,7 @@
- info( "Cleaning up $temp_dir\n" );
+ print "Cleaning up $temp_dir\n";
     File::Path::rmtree([$temp_dir], 0, 0);

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 14 08:10:55 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.