[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for contrib/client-side/svncopy.pl.in

From: Michael W Thelen <mike_at_pietdepsi.com>
Date: 2006-01-13 18:12:08 CET

kfogel@collab.net wrote:
> "Robert Reeves" <robert.reeves@newisys.com> writes:
>>Please let me know if I am following the proper process for submitting
>>patches like this.
>
> This is going to sound ridiculously trivial, but it actually makes a
> big difference:
>
> Could you please attach your patch with a mime-type of "text/plain"
> instead of "application/octet-stream"? Then it would be easy for
> people to review it right in their mailreaders, which vastly increases
> the patch's chances of being applied.

I've reattached Robert's patch as text/plain (I think!)... it's very
small. If no one responds in a day or two, I'll file an issue for it in
the issue tracker.

-- 
Michael W Thelen
It is a mistake to think you can solve any major problems just with
potatoes.       -- Douglas Adams

Index: svncopy.pl.in
===================================================================
--- svncopy.pl.in (revision 17739)
+++ svncopy.pl.in (working copy)
@@ -259,6 +259,7 @@
   chdir( $startdir );
 
   print "=== ... copy complete\n";
+ Temp::Delete->DESTROY($auto_temp_dir);
   print "=================================================================\n";
     
   # Return whether there was an error.
@@ -951,7 +952,7 @@
   }
   else
   {
- info( "Cleaning up $temp_dir\n" );
+ print "Cleaning up $temp_dir\n";
     File::Path::rmtree([$temp_dir], 0, 0);
   }
 }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 13 18:44:14 2006

This is an archived mail posted to the Subversion Dev mailing list.