[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix 2441

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-01-11 22:19:49 CET

Kamesh Jayachandran wrote:
> Hi Julian,
> Thanks for your feedback.
> Attaching the new patch.
> Limiting the header_data to 20 characters as it seems that maximum
> header name that I see in my dump seems to be 20 characters in length.
> In case some spurious binary line happen to be there in the stream we
> limit to print only 20 characters. Don't think it is worth to loop
> through the characters for the valid printable ascii range. Let me know.

I think that's OK, but I also think we should improve most of the other vague
error messages in this same file, otherwise we can't claim to be fixing issue
#2441.

I'm having a go at doing so, starting with a bit of factorisation of the three
code paths that extract a property key or value string from the stream.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 11 22:30:42 2006

This is an archived mail posted to the Subversion Dev mailing list.