[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] move 'svnversion' functionnality in libsvn_wc v3j

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-01-11 00:12:31 CET

Michael W Thelen wrote:
> Fabien COELHO wrote:
>
>>This patch submission and Julian's update has been lost for the past 6
>>weeks. Is it totally lost or in some queue?
>
> Nope, I've been tracking it but I probably should have filed an issue
> for it sooner. If no developer comments on it, or responds to the
> questions Julian posed in his email, I'll go ahead and file an issue for
> it. Thank you for making sure it wasn't forgotten.

Thanks Michael. Go ahead; it's no trouble for me to close the issue when it
does get resolved.

I repeat the questions here for easy reference; the mail containing them and my
version of the patch is archived at
<http://svn.haxx.se/dev/archive-2005-11/1520.shtml>:

> On my version of Fabien's patch, I would like help on these specific questions:
>
> * Is svn_wc_get_status_editor2() called correctly (with associated "open" and
> "close" calls around it)? I'm not familiar enough with it to spot any subtle
> problems.
>
> * Is the "trail_url" a reasonable thing to put in an API? It seems a bit ...
> hackish. Would it be better to require a full expected URL? Would it be
> better to not have the function do that particular processing, but let the
> caller do it?
>
> * The patch removes a bit of code from svnversion that appears to have been
> saying, "If the user cancels, don't error out, just print whatever results we
> have found so far." I think it's fine to remove this, but it's not related to
> the purpose of the patch. I think I should do that in a separate patch. Yes?
> (The "###" in the log message is only a review-stage reminder.)

If an experienced committer says it looks basically OK, I would be prepared to
commit it without having those questions answered specifically.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 11 00:13:44 2006

This is an archived mail posted to the Subversion Dev mailing list.