[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fsfs bug in commit timestamps?

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-01-10 23:52:19 CET

On 1/10/06, Ben Collins-Sussman <sussman@red-bean.com> wrote:

> Looks pretty simple. There's one 'block' of code that fsfs takes out
> an exclusive lock for... the same block which actually moves the
> revision file into place. My guess is that's where svn:date should
> also be set. That's where BDB is doing it, at least (in the bdb txn).

Yeah, that's what I came up with. Here's a patch that looks like it
should fix it. Seems to work, haven't done any really heavy duty
testing on it, so if someone with a little more fsfs background could
take a look I'd appreciate it.

-garrett

Reset svn:date before finalizing commits in fsfs so we can be sure that
the svn:date revprops remain ordered.

* subversion/libsvn_fs_fs/fs_fs.c
  (commit_body): Reset the svn:date revprop before moving the revprops
   file into place when committing a revision.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Jan 10 23:53:31 2006

This is an archived mail posted to the Subversion Dev mailing list.