[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Crash with url-handling

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-01-10 21:00:37 CET

On 10 Jan 2006 12:23:59 -0600, kfogel@collab.net <kfogel@collab.net> wrote:
> Garrett Rooney <rooneg@electricjellyfish.net> writes:
> > Oops, I'm wrong, it's not fixed in trunk, it's just that my trunk
> > build didn't have SSL support turned on. The problem appears to be
> > that we use a strcasecmp to check for https, while neon uses strcmp,
> > and once we think we've got an SSL session, we assume that the SSL
> > parts of the neon session get set up properly... I imagine the
> > correct fix is just to make svn use strcmp like neon does, since even
> > if we're right, it's never worked, and we'll need to be more strict to
> > interoperate with existing neon installs...
>
> I've got a better fix:
>
> In svn_ra_dav__open(), where we run this code:
>
> is_ssl_session = (strcasecmp(uri.scheme, "https") == 0);
>
> If 'is_ssl_session' is true after that, then let's just hard-set
> uri.scheme to "https". After all, it doesn't matter whether the user
> typed "httpS" or whatever. We know it's supposed to be
> case-insensitive, and if we just change it to "https", we'll be
> compatible with Neon, and everything will work.
>
> Don't have time to code & test that right now, but I thought I'd post
> the suggestion here.

I actually did something very similar to this, setting scheme to all
lower case before passing it on to Neon.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 10 21:02:44 2006

This is an archived mail posted to the Subversion Dev mailing list.