[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH, svnmerge] Avoid hitting comand line limits

From: Giovanni Bajo <rasky_at_develer.com>
Date: 2006-01-07 17:26:06 CET

Hello,

one user reported a problem. He uses svnmerge to maintain a large branch
with many cherry-picks. His svnmerge-integrated property is very long and
svnmerge eventually broke: it couldn't invoke "svn propset" anymore because
of command line length limits.

This patch fixes the problem by writing the property to a temporary file,
and calling "svn propset" with -F. We use the new tempfile.mkstemp() which
is free of race-conditions, and fallback to tempfile.mktemp() when running
with Python before 2.4. Not that I expect a race condition to be a problem
here...

Committed as r18011.

[[[
Set properties using "-F" and a temporary file to avoid hitting command
line length limits.

* contrib/client-side/svnmerge.py:
  (_run_propset): New.
  (set_merge_props, set_blocked_revs): Use _run_propset.
]]]

-- 
Giovanni Bajo


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sat Jan 7 17:26:49 2006

This is an archived mail posted to the Subversion Dev mailing list.