[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for #699 XML parser not detected at configure time

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-01-07 01:10:17 CET

On 1/6/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> On 1/6/06, Kamesh Jayachandran <kamesh@collab.net> wrote:
> > Hi Max,
> > Sorry misunderstood your point.
> > Please look at my new patch.
> >
> > With regards
> > Kamesh Jayachandran
> > [[[
> > Fix for #699 XML parser not detected at configure time.
> >
> > * build/ac-macros/neon.m4
> > (SVN_LIB_NEON): Feeds the findings of apr-util to neon.
> >
> > ]]]
>
> This looks good to me. Committed (with some rewriting of the comment)
> in revision 18005.

Oops, it turns out I missinterpreted maxb's plan for solving this
issue. What he was really going for is in aprutil.m4 pulling
apr-util's cflags, cppflags, and includes into our own CPPFLAGS/CFLAGS
variables, so we can be sure we're always using them when they're
needed.

I've reverted the change in the meantime, because it has some other
issues Max pointed out (hardcoded apu-config is a bad thing, for
example, since we could be using apr-util 1.x which uses
apr-1-config), and unfortunately I've timed out on the amount of
effort I can put in to this now, since a low level build change like
that will likely have unforseen consequences and there are a lot of
combinations to test...

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 7 01:11:00 2006

This is an archived mail posted to the Subversion Dev mailing list.