[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix broken SSPI authentication

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-01-06 22:14:25 CET

Hi,

While trying to find out why TortoiseSVN/Subversion couldn't connect to
a repository located on a windows domain anymore if the client wasn't
part of the same domain, I stumbled upon a bug in neon.
The attached patch fixes this. One patch is against trunk, the other
against the 0.25.4 tag.

I've tested the patch with the help of some TortoiseSVN users who
provided me with access to their repositories.

Stefan

(ccing the Subversion dev list, because they might want to include that
patch for their windows binaries build).

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org

Index: src/ne_sspi.c
===================================================================
--- src/ne_sspi.c (Revision 831)
+++ src/ne_sspi.c (Arbeitskopie)
@@ -487,7 +487,7 @@
                                       &outBufferDesc);
         freeBuffer(&inBufferDesc);
     } else {
- if (sspiContext->continueNeeded) {
+ if (!sspiContext->continueNeeded) {
             NE_DEBUG(NE_DBG_HTTPAUTH, "sspi: Expected a token from server.\n");
             return -1;
         }

[[[
Fix endless SSPI authentication.
* src/ne_sspi.c:
  Continue authenticating only if requested.
]]]
Index: src/ne_sspi.c
===================================================================
--- src/ne_sspi.c (Revision 831)
+++ src/ne_sspi.c (Arbeitskopie)
@@ -487,7 +487,7 @@
                                       &outBufferDesc);
         freeBuffer(&inBufferDesc);
     } else {
- if (sspiContext->continueNeeded) {
+ if (!sspiContext->continueNeeded) {
             NE_DEBUG(NE_DBG_HTTPAUTH, "sspi: Expected a token from server.\n");
             return -1;
         }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 6 22:15:26 2006

This is an archived mail posted to the Subversion Dev mailing list.