[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix crash when copying added files with --force

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-01-06 09:48:22 CET

On 1/5/06, Julian Foad <julianfoad@btopenworld.com> wrote:
> Stefan Küng wrote:
> >
> > The first crashreports for TortoiseSVN 1.3.0RC1 are coming in :)
> >
> > When copying added (but not committed yet) files with the --force flag,
> > Subversion crashes in libsvn_wc/copy.c, line 515.
> > That's because there are (IMHO) bogus brackets in the check there.
> >
> > Attached is a patch which fixes this issue.
>
> Are you sure? From my knowledge of C I can't see that removing those brackets
> can make any difference whatsoever.

Autsch.
I think I need some sleep. You're right of course.

But I wonder: the crashreports I received (three so far) indicate that
the strcmp() function was executed even though dst_entry->repos was
NULL.
How could this have happened?

Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 6 09:51:46 2006

This is an archived mail posted to the Subversion Dev mailing list.