[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Possible bug in SVNAdmin.cpp/setLog API?

From: Wascally Wabbit <wascallywabbit_at_earthling.net>
Date: 2006-01-02 18:49:57 CET

As per the FAQ on filing bugs/issues...I'm trying to use SVNAdmin.setLog
via the Java JNI libraries. There seems to be a no-win condition at lines
581-595 in SVNAdmin.cpp in trunk.

     if (revision.revision()->kind != svn_opt_revision_number)
     {
         JNIUtil::handleSVNError(
             svn_error_createf (SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
                               _("Missing revision")));
         return;
     }
     else if (revision.revision()->kind != svn_opt_revision_unspecified)
     {
         JNIUtil::handleSVNError(
             svn_error_createf (SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
                               _("Only one revision allowed")));
       return;
     }

If I pass the first if-clause that means kind == svn_opt_revision_number which
means the subsequent else-if clause will ALWAYS fail (kind is an enum).

Seems like a bug to me...

Thanks,

The Wabbit

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 2 18:50:48 2006

This is an archived mail posted to the Subversion Dev mailing list.