Re: [PATCH] Remove --disable-keychain?

--On December 26, 2005 11:37:38 PM +0000 Malcolm Rowe
<malcolm-svn-dev@farside.org.uk> wrote:

> Hi all,
>
> Is there any particular reason that the OS X KeyChain support added
> recently also spawned a --disable-keychain option to configure?
>
> It seems out-of-place, in that I don't think we have any other 'feature'
> switches in configure (save possibly javahl). We don't have one for the
> wincrypt provider, for example.

There's no other real mechanism on Windows to store the passwords, IIRC.

> If there's no particular reason for it, I'd like to remove the option:
> I can't imagine that anyone building on a Mac _wouldn't_ want the keychain
> provider available, and I'd rather we didn't have configure options for
> every possible feature.
>
> Patch attached; any comments?

I'd prefer we kept it. If only so that folks who don't like the Keychain
on OS X don't have to use it.

In other words, I feel there's little harm in keeping it. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 27 01:17:13 2005