[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17844 - trunk/subversion/libsvn_wc

From: Paul Burba <paulb_at_softlanding.com>
Date: 2005-12-19 19:12:58 CET

Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote on 12/19/2005 12:03:24
PM:

> On Mon, Dec 19, 2005 at 09:00:16AM -0600, pburba@tigris.org wrote:
>
> > [r17844]
>
> I've voted for this change to be backported to 1.3 because it's
obviously
> better than what we have now. I've got a question about the original
> functionality though:
>
> > --- trunk/subversion/libsvn_wc/status.c (original)
> > +++ trunk/subversion/libsvn_wc/status.c Mon Dec 19 09:00:09 2005
> > @@ -1054,7 +1054,7 @@
> > {
> > struct dir_baton *b = baton;
> > if (b->url)
> > - statstruct->url = b->url;
> > + statstruct->url = apr_pstrdup (pool, b->url);
>
> At this point, if b->url was NULL, statstruct->url will retain the same
> value as it had from the call to svn_wc_status2(), and the same is true
> of ood_last_cmt_author. Is this correct in all four cases (the two
here,
> and the two in the file_baton case), or should we be setting either of
> the fields to NULL if the corresponding baton field is NULL?

Hi Malcom,

I don't think that is necessary since svn_wc_status2() calls
assemble_status(), initializing ood_last_cmt_author and url to null.

> [I could imagine that perhaps b->url is never expected to be NULL if
> statstruct->url was non-NULL,

Sorry, I don't follow you on that...did you mean that the other way
around?

Paul B.

> or that statstruct->ood_last_cmt_author
> is always initialised to NULL by svn_wc_status2() --- but neither is
> clear from context.]
>
> Regards,
> Malcolm

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. and SoftLanding Europe Plc by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 19 19:37:49 2005

This is an archived mail posted to the Subversion Dev mailing list.