Re: svn commit: r17844 - trunk/subversion/libsvn_wc

On Mon, Dec 19, 2005 at 09:00:16AM -0600, pburba@tigris.org wrote:

> [r17844]

I've voted for this change to be backported to 1.3 because it's obviously
better than what we have now. I've got a question about the original
functionality though:

> --- trunk/subversion/libsvn_wc/status.c (original)
> +++ trunk/subversion/libsvn_wc/status.c Mon Dec 19 09:00:09 2005
> @@ -1054,7 +1054,7 @@
> {
> struct dir_baton *b = baton;
> if (b->url)
> - statstruct->url = b->url;
> + statstruct->url = apr_pstrdup (pool, b->url);

At this point, if b->url was NULL, statstruct->url will retain the same
value as it had from the call to svn_wc_status2(), and the same is true
of ood_last_cmt_author. Is this correct in all four cases (the two here,
and the two in the file_baton case), or should we be setting either of
the fields to NULL if the corresponding baton field is NULL?

[I could imagine that perhaps b->url is never expected to be NULL if
statstruct->url was non-NULL, or that statstruct->ood_last_cmt_author
is always initialised to NULL by svn_wc_status2() --- but neither is
clear from context.]

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 19 18:38:08 2005