On Thu, Dec 08, 2005 at 06:02:19PM +0000, Malcolm Rowe wrote:
> [problems]
Note that one fairly easy way to alleviate some of the potential for
corruption would be to keep the proto-rev file/stream open for the
duration of the transaction. (And that might not be a bad idea anyway:
it should simplify some of the code slightly, and probably would be a
tiny bit faster as well. It shouldn't cause any scalability problems,
I wouldn't have thought).
We still need to guarantee that the file is closed before we move it
into place, of course, by that's easy once we're only using a single
apr_file_t.
That's not going to be a panacea though, so I wonder whether it'd
be worth thinking about whether there's anything else we can do to
prevent file corruption, like the pre-commit consistency check idea.
(The fact that we can write half a delta-rep, then hit a disk error,
then try again and be left with a wadge of crud at the start of the
permanent rev file is annoying, but I don't think it's a problem that
we need to solve, since the rev file is still perfectly valid).
I'm not going to be able to spend too much time on this for a week or so,
though, so don't expect anything immediately.
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 8 23:13:42 2005