[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r17645 - in trunk/subversion: libsvn_diff

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-12-06 23:54:15 CET

On Tue, 6 Dec 2005 kfogel@collab.net wrote:

> "Peter N. Lundblad" <peter@famlundblad.se> writes:
> > > I realize it's heuristic anyway, but: if we find a CR in the very last
> > > byte we're allowed to look at, then it's "equally" likely that the
> > > next byte is LF as not... In other words, is there a compelling reason
> > > to prefer "\r" over "\r\n" in the unknown case? Wouldn't it be more
> > > consistent to return NULL? In other words:
> >
> > This function is used when the whole file (!) is in memory. Since I'm not
> > saying that this works for a chunk of a file, I'd say this is to be
> > assumed.
>
> But in that case, then NULL really is a more appropriate answer, no?
>
Why? We have the whole file and finds that it ends in a CR. Then it seems
like it uses CR line endings (unless it is truncated, but well...). This
is a file containing just one line.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 7 00:02:15 2005

This is an archived mail posted to the Subversion Dev mailing list.