[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] OSX Keychain support

From: David James <james_at_cs.toronto.edu>
Date: 2005-12-03 19:27:27 CET

On 12/3/05, mark benedetto king <mbk@lowlatency.com> wrote:
> > Shouldn't SVN_KEYCHAIN_INCLUDES and SVN_KEYCHAIN_LIBS be substituted
> > unconditionally? In Makefile.in, I see that @SVN_KEYCHAIN_INCLUDES@
> > was used inside INCLUDES on all platforms.
> >
>
> How about this configure.in change? I think it does everything we
> need, and shouldn't break anything:
> [...]
> +SVN_KEYCHAIN_INCLUDES=""
> +if test "$enable_keychain" = "yes"; then
> + SVN_KEYCHAIN_LIBS="-framework Security"
> + SVN_KEYCHAIN_LIBS="$SVN_KEYCHAIN_LIBS -framework CoreFoundation"
> + SVN_KEYCHAIN_LIBS="$SVN_KEYCHAIN_LIBS -framework CoreServices"
> + AC_DEFINE([SVN_HAVE_KEYCHAIN_SERVICES], [1], [Is Mac OS KeyChain support enabled?])
> + AC_MSG_RESULT([yes])
> +else
> + SVN_KEYCHAIN_LIBS=""
> + AC_MSG_RESULT([no])
> +fi
> +AC_SUBST(SVN_KEYCHAIN_INCLUDES)
> +AC_SUBST(SVN_KEYCHAIN_LIBS)
Looks good!

Cheers,

David

--
David James -- http://www.cs.toronto.edu/~james
Received on Sat Dec 3 19:29:25 2005

This is an archived mail posted to the Subversion Dev mailing list.