[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] OSX Keychain support

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2005-12-03 19:26:19 CET

On 12/2/05, Wilfredo Sánchez Vega <wsanchez@wsanchez.net> wrote:
> I've reworked Ken's patch to work on trunk, added the necessary
> glue to autoconf, and then reworked a few things.
>
> In particular, swapped the use of service name and account around
> to better match what happens with internet passwords (those used by
> Safari), and got rid of static buffer allocations.
>
> Patch file (against today's trunk) is attached.

I took a quick look at this and it seems quite reasonable, although as
mbk mentioned, you seem to have left out keychain_impl.h. The other
thing I noticed is just style, the code seems to jump back and forth
between having a space between a function name and the following paren
and not. It should be consistent with the rest of the code in the
file, which I believe uses the space.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Dec 3 19:28:13 2005

This is an archived mail posted to the Subversion Dev mailing list.