Re: [PATCH] Allow copy files that already copied

On 12/2/05, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> On 12/1/05, Ivan Zhakov <chemodax@gmail.com> wrote:
> > Hi!
> > Current libsvn_wc implementation disallow command sequence like this:
> > touch foo
> > svn add foo
> > svn ci
> > svn cp foo foo2
> > svn cp foo2 foo3
> > svn ci
> >
> > I propose to allow this and make foo3 take foo's URL as copyfrom-url.
> > Look to attached patch.
> > Yes, I know it is bit confusing, but it is usefull, especially for refactoring.
> >
>
> I don't have any objection to this, but I seem to recall that we had
> decided in the past not to allow such things. Perhaps someone can sum
> up the reasons behind it.
>
> As far as the patch itself goes, one minor thing. You have two places
> where you do this:
>
> + if (((src_entry->schedule == svn_wc_schedule_add) &&
> + (!src_entry->copied))
> + || (! src_entry->url))
>
> First off, you should be consistent in the space between the ! and the
> value. Second, perhaps this deserves to be made into a macro or
> something, since there are at least two places that need to be in sync
> with regard to this test.
Thanks, for pointing nits. I hope if feature will be approved, I
remove this check at all. And allow copy added files and directories
too.

--
Ivan Zhakov