Re: [PATCH] Make SVN_STREAM_CHUNK_SIZE internal and tweak it

On Thu, 1 Dec 2005, André Malo wrote:

> > Third party libs can either continue to use the deprecated public macro
> > until 2.0, or make up their own arbitrary buffer size. Having the
> > constant in a central place is mostly for convenience.
>
> Hmm. Your log message sounds like the value has a deeper meaning than being
> convenient. IMHO, if it is a good default for svn streams, it should be
> publically accessable.
>
I was mostly trying to convince people that even if it is used for
unbuffered IO on files, it makes sense. It is not particularly good for
use with svn streams. Using powers of two for IO buffer sizes is just
common.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 1 22:34:02 2005