[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Make SVN_STREAM_CHUNK_SIZE internal and tweak it

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2005-12-01 22:12:28 CET

On Thu, 1 Dec 2005, André Malo wrote:

> * Peter N. Lundblad wrote:
>
> > I wanted to put SVN__STREAM_CHUNK_SIZE in svn_private_config.h to avoid
> > cluttering a public header with an internal constant, but that didn't
> > work in mod_dav_svn, because Apache headers spits out its own autoconf
> > generated macros for everyone to just swallow. I've made it internal,
> > noted that in the docstring and hidden it from doxygen, so I did what I
> > could:-)
> >
> > Any objections?
>
> If you make it private, please add an accessor function to retrieve the
> value. For example, the macro is also often used in bindings applications
> as the default stream buffer size (see svn.fs SVN::CORE etc). Third party
> apps might use it, too.
>
I don't think that's appropriate. I don't see why we should provide a
more or less arbitrary number in our public API. I don't know if we allow
bindings to use internal stuff from the core libraries.

Third party libs can either continue to use the deprecated public macro
until 2.0, or make up their own arbitrary buffer size. Having the
constant in a central place is mostly for convenience.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 1 22:14:02 2005

This is an archived mail posted to the Subversion Dev mailing list.